BUG: resample raises ValueError when NaT is included #7373
Merged
+127
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dt_result = getattr(dt_grouped, func)() | ||
| assert_frame_equal(expected, dt_result) | ||
|
|
||
| # if NaT is included, 'var', 'std', 'mean', 'size', 'first','last' and 'nth' doesn't work yet |
There was a problem hiding this comment.
I get var/std/mean should raise (so add a test for these). the rest should work though, no?
|
There seems to be 3 issues related to aggregation.
|
|
The PR requires |
|
why does how is the |
|
Issued #7453 to explain |
|
ok....going to merge this, and use #7453 to address the other issues |
jreback
added a commit
that referenced
this pull request
Jun 14, 2014
BUG: resample raises ValueError when NaT is included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7227.
resample(how=count)should work now.There are some aggregations which doesn't work with
TimeGrouperyet, I'll open separate issue.